TST: Use indices fixture in tests/indexes/test_base.py

[SaturnFromTitan]

part of #30914

• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff

[SaturnFromTitan]

This line makes that using index without parametrization is identical to writing @pytest.mark.parametrize("indices", ["string"], indirect=True)

[simonjayhawkins]

Thanks @SaturnFromTitan for doing this. This was intended to be a follow-up to #28865 #28865 (comment)

[SaturnFromTitan]

This is now replaced by string_index

[jbrockmendel]

Something I've been trying to do that you might be interested in: these tests are a mix between using indices fixture and self.create_index. If we take all of the create_index methods and put those indexes into the indices fixture, then we can switch over completely to using the fixture.

[SaturnFromTitan]

Good idea @jbrockmendel, I can look into that. Is there a ticket for replacing self.create_index?

[simonjayhawkins]

Thanks @SaturnFromTitan lgtm. could be a smaller diff with #28865 (comment) . wdyt?

[simonjayhawkins]

Thanks @SaturnFromTitan for doing this. This was intended to be a follow-up to #28865 #28865 (comment)

[SaturnFromTitan]

+1 for renaming the fixture to index @simonjayhawkins

I wonder about a good transition strategy though. I could create a fixture index = indices in pandas/conftest.py and then follow-up with a few PRs that replace indices by index. Wdyt?

[simonjayhawkins]

+1 for renaming the fixture to index @simonjayhawkins

I wonder about a good transition strategy though. I could create a fixture index = indices in pandas/conftest.py and then follow-up with a few PRs that replace indices by index. Wdyt?

sounds good. that'll keep the diff here smaller here while allowing others to give their opinions on naming fixtures in general before making changes to other modules.

[SaturnFromTitan]

A much more digestible diff now @simonjayhawkins :)

[jbrockmendel]

I find @pytest.mark.parametrize("index", ["string"], indirect=True) much less clear than index = tm.makeStringIndex(100)

[SaturnFromTitan]

@jbrockmendel I kinda agree. Instead of tm.makeStringIndex(100) we should use a string_index fixture though

[SaturnFromTitan]

@jreback @jbrockmendel @simonjayhawkins
As there seems to be no consent for index as an alternative name for indices, I refrained from introducing an alternative name in this PR altogether. This PR is exclusively using the indices fixture now. The renaming should come in follow-up PRs.

[SaturnFromTitan]

@jreback CI is finally green

[jreback]

sorry a small comment, also merge master and ping on green.

[SaturnFromTitan]

@jreback Using indirect instead of a separate fixture now + CI is green

[jreback]

thanks!

I think it’s worth mentioning in our contributing docs on how - when to use indirect fixtures

[SaturnFromTitan]

xref: #33128