Skip to content

CLN: Removed unnecessary variable call #34949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2020
Merged

CLN: Removed unnecessary variable call #34949

merged 1 commit into from
Jun 23, 2020

Conversation

erfannariman
Copy link
Member

@erfannariman erfannariman mentioned this pull request Jun 23, 2020
Closed
5 tasks
MarcoGorelli
MarcoGorelli approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you prepend CLN to the pull request title?

@erfannariman erfannariman changed the title Removed unnecessary variable call CLN: Removed unnecessary variable call Jun 23, 2020
@erfannariman
Copy link
Member Author

Can you prepend CLN to the pull request title?

Yes done, just for my learning, why are we doing that?

@MarcoGorelli
Copy link
Member

Can you prepend CLN to the pull request title?

Yes done, just for my learning, why are we doing that?

It's just to make it clear what a PR does (e.g. this one cleans up some code)

@TomAugspurger TomAugspurger added this to the 1.1 milestone Jun 23, 2020
@TomAugspurger TomAugspurger merged commit 477fed5 into pandas-dev:master Jun 23, 2020
@TomAugspurger
Copy link
Contributor

Thanks!

@erfannariman erfannariman deleted the remove_variable_34934 branch June 23, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

BUG: unnecessary repetition of variable in explode test
4 participants
@erfannariman @MarcoGorelli @TomAugspurger @simonjayhawkins