Skip to content

Remove exploded variable #34938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 21 commits into from
Closed

Remove exploded variable #34938

wants to merge 21 commits into from

Conversation

erfannariman
Copy link
Member

@erfannariman erfannariman commented Jun 22, 2020 •
edited
Loading

Erfan Nariman | Veneficus and others added 21 commits June 22, 2020 12:47
[IMP] - #34932 - added option to ignore_index in DataFrame.explod
de64663
ENH - #34932 - added docstring ignore_index to explode
136a568
ENH - #34932 - added type to argument
f133297
ENH - #34932 - added ignore_index to Series.explode
4105930
ENH - #34932 - added ignore_index to docstring Series.explode
02e1266
ENH - #34932 - added default to argument ignore_index frame
2f80197
ENH - #34932 - added default to argument ignore_index series
3e85845
ENH - #34932 - added test Series explode ignore_index
fd803ac
ENH - #34932 - added test DataFrame explode ignore_index
4f6a55b
ENH - #34932 - added ignore_index explode to release notes
0a531dd
ENH - #34932 - fixed merge conflicts in release note
0ba378d
@erfannariman
Merge branch 'master' into explode_ignore_index_34932
951a20a
@erfannariman @jorisvandenbossche
update release notes with suggestions
9465319 
Co-authored-by: Joris Van den Bossche <[email protected]>
Added ibase default index instead of reset index
5c59b54
Merge branch 'explode_ignore_index_34932' of github.com:erfannariman/…
288644a 
…pandas into explode_ignore_index_34932
Removed reset_index
a4d28fe
Add type to test Series
5005f96
Changes CI black
b99ad4b
Removed double line break in docstrings
47b985e
@erfannariman
removed redundant repetition of line
92bcb89
@erfannariman
Removed repeated variable
9568df3
@erfannariman
Copy link
Member Author

erfannariman commented Jun 22, 2020 •
edited
Loading

@TomAugspurger would you mind to trigger a rerun here as well? Btw, I'm not sure why my commits of the other branch are shown here..

@erfannariman erfannariman changed the title Remove exploded variable #34934 Remove exploded variable Jun 23, 2020
@MarcoGorelli
Copy link
Member

Btw, I'm not sure why my commits of the other branch are shown here..

This is probably because you created this new branch from the other one. In general, I usually do

git checkout -b <new-pr-branch>
git fetch upstream master
git reset --hard upstream/master

before starting to work on a new PR to make sure this doesn't happen

would you mind to trigger a rerun here as well?

If you rebase onto upstream/master, drop the unrelated commits, and force push, it should re-run

@erfannariman
Copy link
Member Author

@MarcoGorelli I created a new PR, because this branche was messed up. I will close this one, see: #34949

@erfannariman erfannariman deleted the remove_exploded_variable_34934 branch June 23, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: unnecessary repetition of variable in explode test
2 participants
@erfannariman @MarcoGorelli