Skip to content

DOC:updated pie plot legend overlap issue, closes #34288 #34296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2020
Merged

DOC:updated pie plot legend overlap issue, closes #34288 #34296

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d74b3e
DOC:updated pie plot legend overlap issue
wicky1234444 May 21, 2020
e134078
DOC: pie plot white space removal
wicky1234444 May 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/plotting/_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1475,7 +1475,7 @@ def pie(self, **kwargs):
.. plot::
:context: close-figs

>>> plot = df.plot.pie(subplots=True, figsize=(6, 3))
>>> plot = df.plot.pie(subplots=True, figsize=(11, 11))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this there's lots of whitespace above and below, perhaps do this?

Suggested change
>>> plot = df.plot.pie(subplots=True, figsize=(11, 11))
>>> plot = df.plot.pie(subplots=True, figsize=(11, 5))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. I dropping a link to the image here.
pandas-Series-plot-pie-2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i will change that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i forgot add this in the description . closes #34288

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have added the suggested changes. closes #34288

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

closes #34288

Could you add this to the pull request description? I don't know if it works as a keyword if it's just in a comment

"""
if (
isinstance(self._parent, ABCDataFrame)
Expand Down