Skip to content

DOC:updated pie plot legend overlap issue, closes #34288 #34296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2020

Conversation

wicky1234444
Copy link
Contributor

@wicky1234444 wicky1234444 commented May 21, 2020

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wicky1234444 , this looks better

Did you manage to build this page of the documentation locally?

Also, please put the issue number in the description (closes #<issue number goes here>)

@@ -1475,7 +1475,7 @@ def pie(self, **kwargs):
.. plot::
:context: close-figs

>>> plot = df.plot.pie(subplots=True, figsize=(6, 3))
>>> plot = df.plot.pie(subplots=True, figsize=(11, 11))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this there's lots of whitespace above and below, perhaps do this?

Suggested change
>>> plot = df.plot.pie(subplots=True, figsize=(11, 11))
>>> plot = df.plot.pie(subplots=True, figsize=(11, 5))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. I dropping a link to the image here.
pandas-Series-plot-pie-2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i will change that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i forgot add this in the description . closes #34288

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have added the suggested changes. closes #34288

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

closes #34288

Could you add this to the pull request description? I don't know if it works as a keyword if it's just in a comment

@WillAyd WillAyd added the Docs label May 21, 2020
@WillAyd WillAyd added this to the 1.1 milestone May 21, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wicky1234444 wicky1234444 changed the title DOC:updated pie plot legend overlap issue DOC:updated pie plot legend overlap issue, closes #34288 May 21, 2020
@mroeschke mroeschke merged commit 5f19e31 into pandas-dev:master May 23, 2020
@mroeschke
Copy link
Member

Thanks @wicky1234444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: improve pie chart example
4 participants