-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC:updated pie plot legend overlap issue, closes #34288 #34296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wicky1234444 , this looks better
Did you manage to build this page of the documentation locally?
Also, please put the issue number in the description (closes #<issue number goes here>
)
pandas/plotting/_core.py
Outdated
@@ -1475,7 +1475,7 @@ def pie(self, **kwargs): | |||
.. plot:: | |||
:context: close-figs | |||
|
|||
>>> plot = df.plot.pie(subplots=True, figsize=(6, 3)) | |||
>>> plot = df.plot.pie(subplots=True, figsize=(11, 11)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this there's lots of whitespace above and below, perhaps do this?
>>> plot = df.plot.pie(subplots=True, figsize=(11, 11)) | |
>>> plot = df.plot.pie(subplots=True, figsize=(11, 5)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i will change that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry i forgot add this in the description . closes #34288
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have added the suggested changes. closes #34288
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
closes #34288
Could you add this to the pull request description? I don't know if it works as a keyword if it's just in a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @wicky1234444 |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff