Skip to content

CI: temporarily disable interval in feather tests (pyarrow 0.17.1 regression) #34258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2020
Merged

CI: temporarily disable interval in feather tests (pyarrow 0.17.1 regression) #34258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pandas/tests/io/test_feather.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@ def test_basic(self):
if pyarrow_version >= LooseVersion("0.16.1.dev"):
df["periods"] = pd.period_range("2013", freq="M", periods=3)
df["timedeltas"] = pd.timedelta_range("1 day", periods=3)
df["intervals"] = pd.interval_range(0, 3, 3)
# TODO temporary disable due to regression in pyarrow 0.17.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a condition when this can be restored? Eg “When X version Y is released”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on when it will be fixed in pyarrow, so difficult to say for sure at this moment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks. LGTM pending green

# https://github.com/pandas-dev/pandas/issues/34255
# df["intervals"] = pd.interval_range(0, 3, 3)

assert df.dttz.dtype.tz.zone == "US/Eastern"
self.check_round_trip(df)
Expand Down