Skip to content

CI: temporarily disable interval in feather tests (pyarrow 0.17.1 regression) #34258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2020

Conversation

jorisvandenbossche
Copy link
Member

xref #34255

Temporary solution to get green CI.

@jorisvandenbossche jorisvandenbossche added the CI Continuous Integration label May 19, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone May 19, 2020
@@ -83,7 +83,9 @@ def test_basic(self):
if pyarrow_version >= LooseVersion("0.16.1.dev"):
df["periods"] = pd.period_range("2013", freq="M", periods=3)
df["timedeltas"] = pd.timedelta_range("1 day", periods=3)
df["intervals"] = pd.interval_range(0, 3, 3)
# TODO temporary disable due to regression in pyarrow 0.17.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a condition when this can be restored? Eg “When X version Y is released”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on when it will be fixed in pyarrow, so difficult to say for sure at this moment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks. LGTM pending green

@jbrockmendel
Copy link
Member

Travis is green, just hasn't propagated the icon here

@TomAugspurger TomAugspurger merged commit 5691f4e into pandas-dev:master May 19, 2020
@jorisvandenbossche jorisvandenbossche deleted the co-feather-0171 branch May 19, 2020 20:26
PuneethaPai pushed a commit to PuneethaPai/pandas that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants