CLN: Splits Moments and MomentsConsistency tests into separate files

[charlesdong1991]

Due to previous cleaning as well as the large size of those files, we could now split the Moments and MomentsConsistency test classes into two different files for rolling and ewm. And since current test_moments_expanding is actually MomentsConsistencyExpanding class, so rename it to test_moments_consistency_expanding to keep consistency.

And I think this will be the second last PR to close the original test clean issue #30486 . The next PR will be fixturizing the _create_data so that we could remove the Base entirely (which currently only creates those data). But since this base is also used in other several files like test_api.py, test_ewm.py etc in window tests, I am afraid the next PR will be quite big.

Please let me your thoughts on the plan (or if you think the change is quite big then no need to proceed since the original issue is to only clean the moments)?

cc @jreback

[jreback]

can you confirm the number of tests before / after is the same here?

[charlesdong1991]

yep, it's pure copy-paste and no code is missing (also adding/removing imports)

[jreback]

can you merge master and push again, not all checks ran.

[charlesdong1991]

@jreback FYI, i quickly run through tests:

after this PR:
test_moments_ewm.py: 22
test_moments_consistency_ewm.py: 4310
Current master:
test_moments_ewm on master: 4332 

after this PR:
test_moments_rolling.py:253
test_moments_consistency_rolling.py: 10881
Current master:
test_moments_rolling.py: 11134

so i think it's all good, no test missing

[jreback]

looks good. let me re-run.

[jreback]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jreback]

thanks @charlesdong1991