Skip to content

REF: window/test_moments.py #30486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Dec 26, 2019 · 3 comments · Fixed by #34179
Closed

REF: window/test_moments.py #30486

jreback opened this issue Dec 26, 2019 · 3 comments · Fixed by #34179
Assignees
@charlesdong1991
Labels
Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding
Milestone
1.1

Comments

@jreback
Copy link
Contributor

jreback commented Dec 26, 2019

https://github.com/pandas-dev/pandas/blob/master/pandas/tests/window/test_moments.py

this includes testing for ewm/rolling and others. let's put into separate files to make this simpler.
@jreback jreback added Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding labels Dec 26, 2019
@jreback jreback added this to the Contributions Welcome milestone Dec 26, 2019
@charlesdong1991
Copy link
Member

take

@mroeschke
Copy link
Member

@charlesdong1991 if you could find a way to reduce the runtime of some of the tests in this file while maintaining the spirit of the tests, that'd be much appreciated as well! Some of the tests in this file take a while to run.

@charlesdong1991
Copy link
Member

will try @mroeschke

This was referenced Dec 29, 2019
Merged
Merged
Merged
Merged
This was referenced Apr 27, 2020
Merged
Merged
This was referenced May 12, 2020
Merged
Merged
@jreback jreback modified the milestones: Contributions Welcome, 1.1 May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlesdong1991 charlesdong1991

Labels
Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

CLN/TST: Remove Base Class and all subclasses and fixturize data charlesdong1991/pandas
3 participants
@jreback @charlesdong1991 @mroeschke