TST/REF: Parametrize consistency data and de-private methods #33875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesdong1991
changed the title
|
can you confirm number of tests before == number of tests after (adjusting for the fact that you may have parmaterized / added tests) ? can you show a before run so we have an idea here (pass -v to show the tests), might be pretty long. you can also to some extent see where we have tests taking a lot of time (because they are doing many things). |
jreback
added
Testing
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yep, I have roughly verified that the number of tests remains unchanged! Regarding The same applies to For
I also mark i paste the tests before the change here in case you want to verify too! expanding: rolling: |
|
the above looks quite lengthy, please let me know for further questions! @jreback |
|
build failure seems unrelated. @jreback |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 33875 in repo pandas-dev/pandas |
|
thanks @charlesdong1991 very nice. the failure is one we have been seeing occasionally lately but its not consistent. keep em coming on this! |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #30486
I am sorry that this PR looks huge again. @jreback
But this seems a bit unavoidable, and please allow me to briefly explain this, and it is quite simple actually:
_create_consistency_datamethod toconftest.pyand fixturize it asconsistency_data.consistency_dataas fixture, and parametrize it to replace the inner loops.self.data = _create_consistency_data()as part init inConsistencyBase, so I remove it, also a bunch of tests can be moved out of the BIG ConsistencyBase class (which I think is the ultimate goal: avoid using big classes, but simply the functions).test_moments_rolling,test_moments_ewm, andtest_moment_expandingout of their classes to be independent test functionsAfter this PR, we could start reducing the reliance on the giant Base/ConsistencyBase classes, and next step will be fixturize other data and then reduce more reliance on those classes and make tests look smaller.