Skip to content

CLN: Delete no-op check #34082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 10, 2020
Merged

CLN: Delete no-op check #34082

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3fc024
CLN: Delete no-op check
dsaxton May 8, 2020
97c77b7
Merge remote-tracking branch 'upstream/master' into remove-no-op
dsaxton May 9, 2020
d591842
Merge remote-tracking branch 'upstream/master' into remove-no-op
dsaxton May 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions pandas/core/arrays/categorical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2650,11 +2650,8 @@ def _convert_to_list_like(list_like):
return list_like
if is_sequence(list_like) or isinstance(list_like, tuple) or is_iterator(list_like):
return list(list_like)
elif is_scalar(list_like):
return [list_like]
else:
# TODO: is this reached?
return [list_like]

return [list_like]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why we're not doing if is_list_like(x): return x; return [x]?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, that's cleaner and will try

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a lot of things fail if we try that (e.g., tuples need to be converted to lists I think)



def factorize_from_iterable(values):
Expand Down