CLN: Delete no-op check #34082
Merged
CLN: Delete no-op check #34082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
May 8, 2020
| # TODO: is this reached? | ||
| return [list_like] | ||
|
|
||
| return [list_like] |
There was a problem hiding this comment.
any idea why we're not doing if is_list_like(x): return x; return [x]?
There was a problem hiding this comment.
Not sure, that's cleaner and will try
There was a problem hiding this comment.
Looks like a lot of things fail if we try that (e.g., tuples need to be converted to lists I think)
|
ok for now.. can you open an issue / PR on moving this routine elsewhere (maybe pandas.core.common). We do this in quite a few places and would be nice to centalize. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe the note is somehow useful, otherwise I think this can be cleaned?