Skip to content

CLN: Delete no-op check #34082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 10, 2020
Merged

CLN: Delete no-op check #34082

merged 3 commits into from
May 10, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented May 8, 2020

Maybe the note is somehow useful, otherwise I think this can be cleaned?

@dsaxton dsaxton added the Clean label May 8, 2020
# TODO: is this reached?
return [list_like]

return [list_like]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why we're not doing if is_list_like(x): return x; return [x]?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, that's cleaner and will try

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a lot of things fail if we try that (e.g., tuples need to be converted to lists I think)

@jreback jreback added this to the 1.1 milestone May 10, 2020
@jreback jreback merged commit 44e3c40 into pandas-dev:master May 10, 2020
@jreback
Copy link
Contributor

jreback commented May 10, 2020

ok for now..

can you open an issue / PR on moving this routine elsewhere (maybe pandas.core.common). We do this in quite a few places and would be nice to centalize.

@dsaxton dsaxton deleted the remove-no-op branch May 10, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants