Skip to content

BUG: Fixed __join_multi always returning indexers (#34074) #34075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 11, 2020
Merged

BUG: Fixed __join_multi always returning indexers (#34074) #34075

merged 8 commits into from
May 11, 2020

Conversation

CuylenE
Copy link
Contributor

@CuylenE CuylenE commented May 8, 2020 •
edited
Loading

@pep8speaks
Copy link

pep8speaks commented May 8, 2020 •
edited
Loading

Hello @CuylenE! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-05-11 15:56:26 UTC

MarcoGorelli
MarcoGorelli suggested changes May 9, 2020
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CuylenE

Is there a test case for the return_indexers=False case? If not, can you add one?

jreback
jreback requested changes May 10, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also pls add a whatsnew note, bug fixes 1.1., MultiIndex section

MarcoGorelli
MarcoGorelli suggested changes May 11, 2020
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CuylenE , just making a suggestion for the test

@jreback jreback added this to the 1.1 milestone May 11, 2020
@jreback jreback merged commit 2250ddf into pandas-dev:master May 11, 2020
@jreback
Copy link
Contributor

jreback commented May 11, 2020

thanks @CuylenE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli requested changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Bug MultiIndex
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

BUG: Multijoining indexes always returns indexers, ignores function parameters
4 participants
@CuylenE @pep8speaks @jreback @MarcoGorelli