Skip to content

BUG: Multijoining indexes always returns indexers, ignores function parameters #34074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
CuylenE opened this issue May 8, 2020 · 0 comments · Fixed by #34075
Closed
3 tasks done

BUG: Multijoining indexes always returns indexers, ignores function parameters #34074

CuylenE opened this issue May 8, 2020 · 0 comments · Fixed by #34075
Milestone

Comments

@CuylenE
Copy link
Contributor

CuylenE commented May 8, 2020

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • (optional) I have confirmed this bug exists on the master branch of pandas.


Code Sample

>>>frame = pd.DataFrame([(1,2,3,4),(4,5,6,7)],columns=["i1", "i2", "i3","val"]).set_index(["i1","i2","i3"])
>>>frame2 = pd.DataFrame([(1,2,3),(4,5,6)],columns=["i1", "i2", "val"]).set_index(["i1","i2"])
>>>frame.index.join(frame2.index,return_indexers=False)
(MultiIndex([(1, 2, 3),
            (4, 5, 6)],
           names=['i1', 'i2', 'i3']), None, None)

Problem description

Parameter return_indexers is ignored in some cases of __join_multi

Expected Output

>>>frame.index.join(frame2.index,return_indexers=False)
MultiIndex([(1, 2, 3),
            (4, 5, 6)],
           names=['i1', 'i2', 'i3'])
@CuylenE CuylenE added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels May 8, 2020
CuylenE added a commit to CuylenE/pandas that referenced this issue May 8, 2020
@CuylenE CuylenE changed the title BUG: Multijoining indexes always returns indexers BUG: Multijoining indexes always returns indexers, ignores function parameters May 8, 2020
CuylenE added a commit to CuylenE/pandas that referenced this issue May 11, 2020
CuylenE added a commit to CuylenE/pandas that referenced this issue May 11, 2020
CuylenE added a commit to CuylenE/pandas that referenced this issue May 11, 2020
@jreback jreback added this to the 1.1 milestone May 11, 2020
@jreback jreback added MultiIndex and removed Needs Triage Issue that has not been reviewed by a pandas team member labels May 11, 2020
CuylenE added a commit to CuylenE/pandas that referenced this issue May 25, 2020
CuylenE added a commit to CuylenE/pandas that referenced this issue May 25, 2020
CuylenE added a commit to CuylenE/pandas that referenced this issue May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants