Skip to content

TYP/CLN: remove #type: ignore from pandas\tests\test_strings.py #33862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2020
Merged

TYP/CLN: remove #type: ignore from pandas\tests\test_strings.py #33862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
861e4a5
TYP/CLN: remove #type: ignore from pandas\tests\test_strings.py
simonjayhawkins Apr 29, 2020
1e459d3
Merge remote-tracking branch 'upstream/master' into pandas-tests-test…
simonjayhawkins Apr 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pandas/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,10 @@ def index_or_series(request):
return request.param


# Generate cartesian product of index_or_series fixture:
index_or_series2 = index_or_series


@pytest.fixture
def dict_subclass():
"""
Expand Down
8 changes: 2 additions & 6 deletions pandas/tests/test_strings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,14 +671,10 @@ def test_str_cat_align_mixed_inputs(self, join):
with pytest.raises(ValueError, match=rgx):
s.str.cat([t, z], join=join)

index_or_series2 = [Series, Index] # type: ignore
# List item 0 has incompatible type "Type[Series]"; expected "Type[PandasObject]"
# See GH#29725

@pytest.mark.parametrize("other", index_or_series2)
def test_str_cat_all_na(self, index_or_series, other):
def test_str_cat_all_na(self, index_or_series, index_or_series2):
# GH 24044
box = index_or_series
other = index_or_series2

# check that all NaNs in caller / target work
s = Index(["a", "b", "c", "d"])
Expand Down