Skip to content

TYP/CLN: remove #type: ignore from pandas\tests\test_strings.py #33862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

simonjayhawkins
Copy link
Member

No description provided.

@simonjayhawkins simonjayhawkins added Clean Typing type annotations, mypy/pyright type checking labels Apr 29, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; at first glance failures look unrelated

@WillAyd WillAyd added this to the 1.1 milestone Apr 29, 2020
@jbrockmendel
Copy link
Member

yah, the test failures are affecting every PR ATM, unfortunately i cant reproduce locally

@jreback jreback merged commit bf81fc8 into pandas-dev:master Apr 29, 2020
@jreback
Copy link
Contributor

jreback commented Apr 29, 2020

thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the pandas-tests-test_strings.py branch April 30, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants