Skip to content

CI/DEP: Use numba.extending.is_jitted for numba version > 0.49.0 #33687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke changed the title Use numba.extending.is_jitted for numba version > 0.50 Use numba.extending.is_jitted for numba version > 0.49.0 Apr 20, 2020
@mroeschke mroeschke changed the title Use numba.extending.is_jitted for numba version > 0.49.0 CI/DEP: Use numba.extending.is_jitted for numba version > 0.49.0 Apr 20, 2020
@mroeschke mroeschke added CI Continuous Integration Dependencies Required and optional dependencies labels Apr 20, 2020
@mroeschke mroeschke added this to the 1.1 milestone Apr 20, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm merge on green (are we testing <0.49 anywhere? maybe fix it in one of the older builds)

@mroeschke
Copy link
Member Author

azure-36-minimum_versions.yaml is testing numba = 0.46.0, so we should be covered

@mroeschke mroeschke merged commit e0d4622 into pandas-dev:master Apr 20, 2020
@mroeschke mroeschke deleted the is_jitted branch April 20, 2020 22:50
@simonjayhawkins
Copy link
Member

@meeseeksdev backport to 1.0.x

@lumberbot-app
Copy link

lumberbot-app bot commented May 4, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.0.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 e0d4622cb7189adba8fc65571ff5a608564f8c67
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #33687: CI/DEP: Use numba.extending.is_jitted for numba version > 0.49.0'
  1. Push to a named branch :
git push YOURFORK 1.0.x:auto-backport-of-pr-33687-on-1.0.x
  1. Create a PR against branch 1.0.x, I would have named this PR:

"Backport PR #33687 on branch 1.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants