Skip to content

BLD: Set max version of numba to 0.48.0 #33686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mgmarino
Copy link
Contributor

This should fix the errors in the CI (Travis) builds, e.g.

E       AttributeError: module 'numba' has no attribute 'targets'

This will fix the errors in the CI (Travis) builds, e.g.

```
E       AttributeError: module 'numba' has no attribute 'targets'
```
@mgmarino mgmarino marked this pull request as ready for review April 20, 2020 21:20
@jbrockmendel
Copy link
Member

makes sense, cc @mroeschke

@mroeschke
Copy link
Member

Ah. This had slipped my mind.

The reason this is failing is due to numba/numba#5256 (comment)

I'm working on the patch right now that would be preferable to pinning the numba version, but if this is blocking anything urgent, happy to merge

@mroeschke
Copy link
Member

#33687 should equivalently fix the failing builds due to numba v0.50.0

@mgmarino
Copy link
Contributor Author

Sounds good, closing in favor of #33687

@mgmarino mgmarino closed this Apr 20, 2020
@jreback jreback added the Dependencies Required and optional dependencies label Apr 20, 2020
@jreback jreback added this to the 1.1 milestone Apr 20, 2020
@mroeschke
Copy link
Member

@mgmarino thanks for the catch. Merged in #33687 so things should be working now

@mgmarino mgmarino deleted the set-max-version-of-numba branch May 27, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants