Skip to content

CLN: Cython warnings for type declartions #33617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2020
+3 −3
Merged

CLN: Cython warnings for type declartions #33617

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ea458d
Cln cython warnings
alimcmaster1 Apr 18, 2020
fbf3235
Merge remote-tracking branch 'upstream/master' into cython-warnings
alimcmaster1 Apr 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pandas/_libs/internals.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,10 @@ cdef class BlockPlacement:

return BlockPlacement(val)

def delete(self, loc) -> "BlockPlacement":
def delete(self, loc) -> BlockPlacement:
return BlockPlacement(np.delete(self.as_array, loc, axis=0))

def append(self, others) -> "BlockPlacement":
def append(self, others) -> BlockPlacement:
if not len(others):
return self

Expand Down Expand Up @@ -185,7 +185,7 @@ cdef class BlockPlacement:
val = newarr
return BlockPlacement(val)

def add(self, other) -> "BlockPlacement":
def add(self, other) -> BlockPlacement:
# We can get here with int or ndarray
return self.iadd(other)

Expand Down