Skip to content

CLN: Cython warnings for type declartions #33617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2020

Conversation

alimcmaster1
Copy link
Member

warning: pandas/_libs/internals.pyx:144:29: Strings should no longer be used for type declarations. Use 'cython.int' etc. directly.
warning: pandas/_libs/internals.pyx:147:32: Strings should no longer be used for type declarations. Use 'cython.int' etc. directly.
warning: pandas/_libs/internals.pyx:188:28: Strings should no longer be used for type declarations. Use 'cython.int' etc. directly.

(Against cython master)

@alimcmaster1 alimcmaster1 added Clean Typing type annotations, mypy/pyright type checking labels Apr 18, 2020
@WillAyd
Copy link
Member

WillAyd commented Apr 18, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@WillAyd
Copy link
Member

WillAyd commented Apr 18, 2020

Can you merge master again; doesn't look like all the checks have run. Chance this might not work with Py36 but will see in CI (maybe PEP 563 is a pre-cursor)

@alimcmaster1
Copy link
Member Author

@WillAyd thanks - all checks have run now

@WillAyd
Copy link
Member

WillAyd commented Apr 18, 2020

lgtm. I suppose this differs slightly from Python annotation requirements before PEP 563 was implemented but I don't have any objection unless @scoder knows any better

@scoder
Copy link

scoder commented Apr 18, 2020

Hmm … yeah, that's PEP-563. I think it's really best to move forward with this and use real types in annotations instead of string names.

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Apr 19, 2020
@jreback jreback merged commit 9590c5b into pandas-dev:master Apr 19, 2020
@jreback
Copy link
Contributor

jreback commented Apr 19, 2020

thanks @alimcmaster1

CloseChoice pushed a commit to CloseChoice/pandas that referenced this pull request Apr 20, 2020
@alimcmaster1 alimcmaster1 deleted the cython-warnings branch May 1, 2020 22:03
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants