-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: Cython warnings for type declartions #33617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Can you merge master again; doesn't look like all the checks have run. Chance this might not work with Py36 but will see in CI (maybe PEP 563 is a pre-cursor) |
@WillAyd thanks - all checks have run now |
lgtm. I suppose this differs slightly from Python annotation requirements before PEP 563 was implemented but I don't have any objection unless @scoder knows any better |
Hmm … yeah, that's PEP-563. I think it's really best to move forward with this and use real types in annotations instead of string names. |
thanks @alimcmaster1 |
(Against cython master)