Skip to content

CI: Fix jedi deprecation warning for 0.17.0 on IPython #33566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 15, 2020
Merged

CI: Fix jedi deprecation warning for 0.17.0 on IPython #33566

merged 11 commits into from
Apr 15, 2020

Conversation

charlesdong1991
Copy link
Member

@charlesdong1991 charlesdong1991 commented Apr 15, 2020 •
edited
Loading

@charlesdong1991
Copy link
Member Author

charlesdong1991 commented Apr 15, 2020 •
edited
Loading

similar to #31323, a fix needs to take place in IPython.

jbrockmendel
jbrockmendel reviewed Apr 15, 2020
View reviewed changes
pandas/tests/resample/test_resampler_grouper.py
@@ -28,7 +28,17 @@ async def test_tab_complete_ipython6_warning(ip):
)
await ip.run_code(code)

with tm.assert_produces_warning(None):
# TODO: remove it when Ipython updates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the GH ref here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, added!

@jbrockmendel
Copy link
Member

ex small comment, LGTM pending green

@charlesdong1991 charlesdong1991 added the CI Continuous Integration label Apr 15, 2020
@jbrockmendel jbrockmendel merged commit 8af5625 into pandas-dev:master Apr 15, 2020
@jbrockmendel
Copy link
Member

Thanks @charlesdong1991

@charlesdong1991 charlesdong1991 deleted the fix_jedi_deprecation branch April 16, 2020 07:25
CloseChoice pushed a commit to CloseChoice/pandas that referenced this pull request Apr 20, 2020
@charlesdong1991 @CloseChoice
CI: Fix jedi deprecation warning for 0.17.0 on IPython (pandas-dev#33566
bb0fa7e 
)

* remove \n from docstring

* fix issue 17038

* revert change

* revert change

* fix jedi ci

* linting and add gh
@simonjayhawkins
Copy link
Member

@meeseeksdev backport to 1.0.x

@meeseeksmachine meeseeksmachine mentioned this pull request May 4, 2020
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request May 4, 2020
@charlesdong1991 @meeseeksmachine
Backport PR pandas-dev#33566: CI: Fix jedi deprecation warning for 0.…
f6641af 
…17.0 on IPython
simonjayhawkins pushed a commit that referenced this pull request May 4, 2020
@meeseeksmachine @charlesdong1991
Backport PR #33566: CI: Fix jedi deprecation warning for 0.17.0 on IP…
1fdb49d 
…ython (#33972)

Co-authored-by: Kaiqi Dong <[email protected]>
@simonjayhawkins simonjayhawkins added this to the 1.0.4 milestone May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
1.0.4
Development

Successfully merging this pull request may close these issues.

CI : jedi deprecation warnings fails CI
3 participants
@charlesdong1991 @jbrockmendel @simonjayhawkins