Skip to content

CI: Fix jedi upgrades causes deprecation warning #31323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 27, 2020

Conversation

charlesdong1991
Copy link
Member

@charlesdong1991 charlesdong1991 commented Jan 26, 2020

@alimcmaster1 alimcmaster1 added CI Continuous Integration Dependencies Required and optional dependencies labels Jan 26, 2020
@alimcmaster1
Copy link
Member

Assume the warning is raised in the Jedi code? Is there an issue open upstream - so hopefully this gets fixed?

@charlesdong1991
Copy link
Member Author

charlesdong1991 commented Jan 26, 2020

emm, will take a look at jedi and see if a new issue is needed there
@alimcmaster1

- Big **Script API Changes**:
    - The line and column parameters of ``jedi.Script`` are now deprecated
    - ``completions`` deprecated, use ``complete`` instead
    - ``goto_assignments`` deprecated, use ``goto`` instead
    - ``goto_definitions`` deprecated, use ``infer`` instead
    - ``call_signatures`` deprecated, use ``get_signatures`` instead
    - ``usages`` deprecated, use ``get_references`` instead
    - ``jedi.names`` deprecated, use ``jedi.Script(...).get_names()``
- ``BaseDefinition.goto_assignments`` renamed to ``BaseDefinition.goto``

Update:
i opened an issue there, and see if can get a quick response and see where issue should be solved, maybe for now we could leave a TODO first and merge this to make CI green
davidhalter/jedi#1481

Update2:
based on explanation from jedi, seems ipython uses something which is deprecated in jedi and raises warning in the latest version, so we see a warning here.

@simonjayhawkins simonjayhawkins added this to the 1.0.0 milestone Jan 27, 2020
@jreback jreback merged commit e61f47a into pandas-dev:master Jan 27, 2020
@jreback
Copy link
Contributor

jreback commented Jan 27, 2020

thanks @charlesdong1991

can you create an issue to see what we should do once a new jedi is released (e.g. revert this patch), but maybe we do nothing.

@charlesdong1991
Copy link
Member Author

based on jedi explanation, I think Ipython needs to react on the deprecation, and I will create an issue here and also in ipython later tonight.

Once ipython changes and no longer raises warning, i think we could revert the change then. @jreback

ShaharNaveh pushed a commit to ShaharNaveh/pandas that referenced this pull request Feb 1, 2020
ShaharNaveh pushed a commit to ShaharNaveh/pandas that referenced this pull request Feb 22, 2020
ShaharNaveh added a commit to ShaharNaveh/pandas that referenced this pull request Mar 27, 2020
ShaharNaveh pushed a commit to ShaharNaveh/pandas that referenced this pull request Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: seems jedi caused ci to fail in certain versions
4 participants