add a new feature sample() into groupby

[echozzy629]

• closes CI: add doctest check for done modules #33175
• 0 tests added / 0 passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff

[pep8speaks]

Hello @echozzy629! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file pandas/core/base.py:

Line 441:17: E265 block comment should start with '# '
Line 442:89: E501 line too long (106 > 88 characters)
Line 443:17: E265 block comment should start with '# '
Line 443:89: E501 line too long (137 > 88 characters)
Line 444:28: E225 missing whitespace around operator
Line 446:34: E225 missing whitespace around operator
Line 447:32: E225 missing whitespace around operator
Line 449:32: E225 missing whitespace around operator
Line 450:89: E501 line too long (96 > 88 characters)

• In the file pandas/core/groupby/groupby.py:

Line 1459:1: W293 blank line contains whitespace
Line 1468:89: E501 line too long (119 > 88 characters)
Line 1474:1: W293 blank line contains whitespace
Line 1483:89: E501 line too long (97 > 88 characters)
Line 1487:89: E501 line too long (93 > 88 characters)
Line 1494:26: E225 missing whitespace around operator
Line 1495:1: W293 blank line contains whitespace
Line 1496:9: E265 block comment should start with '# '
Line 1497:13: E116 unexpected indentation (comment)
Line 1497:13: E265 block comment should start with '# '
Line 1498:17: E711 comparison to None should be 'if cond is None:'
Line 1499:23: E225 missing whitespace around operator
Line 1500:1: W293 blank line contains whitespace
Line 1501:9: E265 block comment should start with '# '
Line 1502:19: E711 comparison to None should be 'if cond is None:'
Line 1503:23: E225 missing whitespace around operator
Line 1503:38: E226 missing whitespace around arithmetic operator
Line 1505:9: E265 block comment should start with '# '
Line 1506:63: E225 missing whitespace around operator
Line 1507:23: E225 missing whitespace around operator
Line 1508:63: E225 missing whitespace around operator
Line 1510:9: E265 block comment should start with '# '
Line 1514:64: E225 missing whitespace around operator
Line 1516:9: E265 block comment should start with '# '
Line 1518:9: E115 expected an indented block (comment)
Line 1518:9: E265 block comment should start with '# '
Line 1519:9: E115 expected an indented block (comment)
Line 1519:9: E265 block comment should start with '# '
Line 1520:9: E115 expected an indented block (comment)
Line 1522:9: E115 expected an indented block (comment)
Line 1522:9: E265 block comment should start with '# '
Line 1524:89: E501 line too long (112 > 88 characters)
Line 1525:1: W293 blank line contains whitespace
Line 1526:9: E265 block comment should start with '# '
Line 1527:25: E225 missing whitespace around operator
Line 1529:16: E111 indentation is not a multiple of four
Line 1529:89: E501 line too long (119 > 88 characters)
Line 1530:1: W293 blank line contains whitespace
Line 1532:22: E225 missing whitespace around operator
Line 1536:9: E265 block comment should start with '# '
Line 1536:9: E303 too many blank lines (2)
Line 1537:16: E225 missing whitespace around operator
Line 1537:30: E225 missing whitespace around operator
Line 1539:16: E225 missing whitespace around operator
Line 1539:51: E225 missing whitespace around operator
Line 1540:89: E501 line too long (130 > 88 characters)
Line 1543:13: E265 block comment should start with '# '
Line 1545:89: E501 line too long (90 > 88 characters)
Line 1547:17: E265 block comment should start with '# '
Line 1552:21: E225 missing whitespace around operator
Line 1553:22: E225 missing whitespace around operator
Line 1556:28: E225 missing whitespace around operator
Line 1557:32: E225 missing whitespace around operator
Line 1558:32: E225 missing whitespace around operator
Line 1562:28: E225 missing whitespace around operator
Line 1566:9: E265 block comment should start with '# '
Line 1567:9: E265 block comment should start with '# '
Line 1568:24: E225 missing whitespace around operator
Line 1569:20: E225 missing whitespace around operator
Line 1570:15: E225 missing whitespace around operator
Line 1570:44: E231 missing whitespace after ','
Line 1570:60: E231 missing whitespace after ','
Line 1570:76: E231 missing whitespace after ','
Line 1571:20: E225 missing whitespace around operator
Line 1574:26: E225 missing whitespace around operator
Line 1574:89: E501 line too long (104 > 88 characters)

Comment last updated at 2020-04-13 06:38:10 UTC

[alimcmaster1]

@echozzy629

Thanks for the PR please can you fix up the following

• Test failures there seems to be alot (merging master will help for np dev build)
• run flake8 and black
• Can you please ref the correct issue - currently doesn't look correct.

Our contributing guide might help:
https://pandas.pydata.org/docs/development/contributing.html

[alimcmaster1]

See comments

[MarcoGorelli]

Thanks @echozzy629

Is this still active? If so, can you please address @alimcmaster1 's review?

Also, this would close #31775, not #33175

[MarcoGorelli]

Closing due to lack of response, feel free to reopen if you address @alimcmaster1 's feedback