Skip to content

CI: add doctest check for done modules #33175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2020
Merged

CI: add doctest check for done modules #33175

merged 2 commits into from
Mar 31, 2020

Conversation

ShaharNaveh
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@ShaharNaveh ShaharNaveh force-pushed the CI-DoneDoctestModulesCheck branch from e3dffc4 to a9bdde5 Compare March 31, 2020 10:38
MomIsBestFriend added 2 commits March 31, 2020 13:40
CI: Add doctest check for done modules
a9bdde5
Removed empty checks
702dc0f 
When running `pytest --doctest-modules` and no tests are found
the return status code is 5.
Meaning that `$RET` is going to be larger than 0.
@jreback jreback added CI Continuous Integration Docs labels Mar 31, 2020
@jreback jreback added this to the 1.1 milestone Mar 31, 2020
@jreback jreback merged commit 0fbdf48 into pandas-dev:master Mar 31, 2020
@jreback
Copy link
Contributor

jreback commented Mar 31, 2020

thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the CI-DoneDoctestModulesCheck branch March 31, 2020 13:14
@echozzy629 echozzy629 mentioned this pull request Apr 13, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous Integration Docs
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaharNaveh @jreback