-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DEP: Bump min version of dateutil to 2.7.3 #33363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: Bump min version of dateutil to 2.7.3 #33363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @MomIsBestFriend
Can you have a look at the CI and see what's wrong please?
In 1.0, we had dependency bumps under the "Backwards incompatible" section. https://pandas.pydata.org/docs/whatsnew/v1.0.0.html#increased-minimum-versions-for-dependencies. We can do that again, or make a new top-level section. |
so, by definition, this is an breaking change? is this necessary or can it keep till 2.0? |
Haven't thought of that. I'll push more commits when someone from the pandas-core team will tell me if this PR is relevant :) |
I wouldn't consider this an API breaking change. That's just the header it went under in older versions. |
@datapythonista I have found out that there is a bug in 2.7.0 that was fixed in 2.7.3 when parsing a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thanks @MomIsBestFriend as a followon can you see if we can change code for anything that needed < 2.7.3 (i don't know if there is anything, but its possible). |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
Not sure where to put the note in the "whatsnew"