TST: Fixed xfail for tests in pandas/tests/tseries/offsets/test_offsets_properties.py #32465

ShaharNaveh · 2020-03-05T16:08:18Z

ref CLN: Using clearer imports #32459 (comment)
tests added / passed
passes black pandas
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

ShaharNaveh · 2020-03-05T16:09:16Z

pandas/tests/tseries/offsets/test_offsets_properties.py

@@ -85,8 +85,6 @@
 # Offset-specific behaviour tests


-# Based on CI runs: Always passes on OSX, fails on Linux, sometimes on Windows
-@pytest.mark.xfail(strict=False, reason="inconsistent between OSs, Pythons")


It says here that on linux it always fails (at least this is how I understood it), but it passed on my machine (I run linux).

Ok so I think I understood why this failing:

hypothesis.extra.dateutil.timezones is using dateutil.UTC which is avaible only from dateutils>=2.7.0 (https://dateutil.readthedocs.io/en/stable/tz.html#dateutil.tz.dateutil.tz.UTC)

but macOS have a pinned python-dateutils to 2.6.1 which then leads to errors.

@jbrockmendel is bumping python-dateutils to 2.7.0 is an option/reasonable thing to do?

if not I will put a pytest.mark.skipif decorator (seems more likely to be the answer)

is bumping python-dateutils to 2.7.0 is an option/reasonable thing to do?

2.7.0 is 2 days shy of 2 years old, so I think we're OK bumping

@MomIsBestFriend this is definitely an improvement, but we can also just bump the dateutil requirement

@MomIsBestFriend this is definitely an improvement, but we can also just bump the dateutil requirement

Sure! will do that in a separate PR

ShaharNaveh · 2020-03-05T16:09:59Z

pandas/tests/tseries/offsets/test_offsets_properties.py

    assert res[0] == rng[0] + offset
    assert res[-1] == rng[-1] + offset
    res2 = ser + offset
-    # apply_index is only for indexes, not series, so no res2_v2
+
+    # TODO: Check randomly assorted entries, not just first/last


I am interested in doing that, anyone got a smart way of doing that?

Will do that in a follow-up PR.

for _ in range(10): n = np.random.randint(len(ser)) assert res2.iloc[n] == ser.iloc[n] + offset

(10 is arbitrary number here, you decide what is reasonable number

pandas/tests/tseries/offsets/test_offsets_properties.py

ShaharNaveh · 2020-03-05T17:52:01Z

mypy is failing?

jbrockmendel · 2020-03-09T22:42:46Z

pandas/tests/tseries/offsets/test_offsets_properties.py

@@ -101,7 +103,7 @@ def test_on_offset_implementations(dt, offset):


 @pytest.mark.skipif(
-    dateutil.__version__ < "2.7",
+    DATEUTIL_VERSION < "2.7",
    reason="hypothesis uses dateutil.tz.UTC which was intreduced in dateutils 2.7.0",


intreduced -> introduced

jbrockmendel · 2020-03-09T22:42:55Z

pandas/tests/tseries/offsets/test_offsets_properties.py

@@ -101,7 +103,7 @@ def test_on_offset_implementations(dt, offset):


 @pytest.mark.skipif(
-    dateutil.__version__ < "2.7",
+    DATEUTIL_VERSION < "2.7",


can you use LooseVersion

jbrockmendel · 2020-03-18T19:33:37Z

looks like the build logs have expired; can you rebase and we'll see if this is ready

REF: pandas-dev#32465 (comment)

pandas/tests/tseries/offsets/test_offsets_properties.py

REF: pandas-dev#32465 (comment)

pandas/tests/tseries/offsets/test_offsets_properties.py

jbrockmendel · 2020-03-25T17:39:56Z

pandas/tests/tseries/offsets/test_offsets_properties.py


-    # rng = pd.date_range(start='1/1/2000', periods=100000, freq='T')
+    # TODO: Remove this `warnings.simplefilter`


what are the conditions that will allow this?

I can't remebmer why was this necessery, Ill remove it, and see if the CI passes

jbrockmendel · 2020-03-25T17:42:51Z

Couple of comments, looks nearly there

REF: pandas-dev#32465 (comment)

This reverts commit 635b28e.

jbrockmendel · 2020-04-11T21:53:10Z

=================================== FAILURES ===================================
_______________________ test_apply_index_implementations _______________________
[gw1] linux -- Python 3.6.10 /home/vsts/miniconda3/envs/pandas-dev/bin/python

    @given(gen_yqm_offset, gen_date_range)
>   def test_apply_index_implementations(offset, rng):

pandas/tests/tseries/offsets/test_offsets_properties.py:99: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
pandas/core/indexes/datetimes.py:974: in date_range
    **kwargs,
pandas/core/arrays/datetimes.py:412: in _generate_range
    index.asi8, tz, ambiguous=ambiguous, nonexistent=nonexistent
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

>   raise pytz.NonExistentTimeError(stamp)
E   pytz.exceptions.NonExistentTimeError: 1991-03-31 00:04:11.080387

pandas/_libs/tslibs/tzconversion.pyx:276: NonExistentTimeError

alimcmaster1 · 2020-05-23T23:33:42Z

Is this still active?

jreback · 2020-06-14T17:27:09Z

closing as stale; if you can continue pls ping / open a new PR.

MomIsBestFriend added 3 commits March 5, 2020 17:54

TST: Cleaned tests

4fd071c

Fixed another test

d69692c

Cosmetic changes

6112ddd

ShaharNaveh commented Mar 5, 2020

View reviewed changes

pandas/tests/tseries/offsets/test_offsets_properties.py Show resolved Hide resolved

ShaharNaveh changed the title ~~Tst tseries xfail~~ TST: Fixed xfail for tests in pandas/tests/tseries/offsets/test_offsets_properties.py Mar 5, 2020

simonjayhawkins added the Testing pandas testing functions or related to the test suite label Mar 5, 2020

ShaharNaveh force-pushed the TST-tseries-xfail branch from 4ea120e to 6112ddd Compare March 5, 2020 17:10

Skiping tests if dateutils 2.7.0 or higher is not installed

86415fa

MomIsBestFriend added 2 commits March 6, 2020 10:14

Merge remote-tracking branch 'upstream/master' into TST-tseries-xfail

10f5b72

Suppressing mypy errors

a1ad09b

jbrockmendel reviewed Mar 9, 2020

View reviewed changes

MomIsBestFriend added 5 commits March 18, 2020 22:06

Merge remote-tracking branch 'upstream/master' into TST-tseries-xfail

f18e402

Using LooseVersion

30d9ef7

REF: pandas-dev#32465 (comment)

Merge remote-tracking branch 'upstream/master' into TST-tseries-xfail

6cc8bc4

Added simplefilter for warnings

9087485

Typos

889b726

REF: pandas-dev#32465 (comment)

simonjayhawkins reviewed Mar 19, 2020

View reviewed changes

pandas/tests/tseries/offsets/test_offsets_properties.py Outdated Show resolved Hide resolved

MomIsBestFriend added 2 commits March 19, 2020 18:39

Using td.skip.if_no decorator

a33bb0c

REF: pandas-dev#32465 (comment)

Merge remote-tracking branch 'upstream/master' into TST-tseries-xfail

5f4c9a6

jbrockmendel reviewed Mar 25, 2020

View reviewed changes

pandas/tests/tseries/offsets/test_offsets_properties.py Show resolved Hide resolved

jbrockmendel reviewed Mar 25, 2020

View reviewed changes

MomIsBestFriend added 3 commits March 25, 2020 20:44

Delted duplicate apply_index

d8a51f6

REF: pandas-dev#32465 (comment)

Remove warnings.simplefilter

3a508cf

Merge remote-tracking branch 'upstream/master' into TST-tseries-xfail

5251350

MomIsBestFriend added 9 commits March 29, 2020 15:18

Merge remote-tracking branch 'upstream/master' into TST-tseries-xfail

7507faa

Trying with smaller daterange

635b28e

Revert "Trying with smaller daterange"

baf83d4

This reverts commit 635b28e.

Merge remote-tracking branch 'upstream/master' into TST-tseries-xfail

9389578

Merge remote-tracking branch 'upstream/master' into TST-tseries-xfail

1802c60

Merge remote-tracking branch 'upstream/master' into TST-tseries-xfail

273ca9d

Merge remote-tracking branch 'upstream/master' into TST-tseries-xfail

664411f

Merge remote-tracking branch 'upstream/master' into TST-tseries-xfail

e148ca7

Merge remote-tracking branch 'upstream/master' into TST-tseries-xfail

0ea0151

ShaharNaveh mentioned this pull request Apr 7, 2020

DEP: Bump min version of dateutil to 2.7.3 #33363

Merged

5 tasks

MomIsBestFriend added 4 commits April 8, 2020 12:26

Merge remote-tracking branch 'upstream/master' into TST-tseries-xfail

5656456

Merge remote-tracking branch 'upstream/master' into TST-tseries-xfail

648d17f

Removed skip decorators

e4a9d0b

Merge remote-tracking branch 'upstream/master' into TST-tseries-xfail

80ad207

jreback closed this Jun 14, 2020

ShaharNaveh deleted the TST-tseries-xfail branch May 3, 2021 12:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TST: Fixed xfail for tests in pandas/tests/tseries/offsets/test_offsets_properties.py #32465

TST: Fixed xfail for tests in pandas/tests/tseries/offsets/test_offsets_properties.py #32465

ShaharNaveh commented Mar 5, 2020

ShaharNaveh Mar 5, 2020 •

edited

Loading

ShaharNaveh Mar 5, 2020 •

edited

Loading

jbrockmendel Mar 9, 2020

jbrockmendel Apr 6, 2020

ShaharNaveh Apr 7, 2020

ShaharNaveh Mar 5, 2020 •

edited

Loading

jbrockmendel Mar 25, 2020

ShaharNaveh commented Mar 5, 2020

jbrockmendel Mar 9, 2020

jbrockmendel Mar 9, 2020

jbrockmendel commented Mar 18, 2020

jbrockmendel Mar 25, 2020

ShaharNaveh Mar 25, 2020

jbrockmendel commented Mar 25, 2020

jbrockmendel commented Apr 11, 2020

alimcmaster1 commented May 23, 2020

jreback commented Jun 14, 2020


		# rng = pd.date_range(start='1/1/2000', periods=100000, freq='T')
		# TODO: Remove this `warnings.simplefilter`

TST: Fixed xfail for tests in pandas/tests/tseries/offsets/test_offsets_properties.py #32465

TST: Fixed xfail for tests in pandas/tests/tseries/offsets/test_offsets_properties.py #32465

Conversation

ShaharNaveh commented Mar 5, 2020

ShaharNaveh Mar 5, 2020 • edited Loading

Choose a reason for hiding this comment

ShaharNaveh Mar 5, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShaharNaveh Mar 5, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShaharNaveh commented Mar 5, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbrockmendel commented Mar 18, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbrockmendel commented Mar 25, 2020

jbrockmendel commented Apr 11, 2020

alimcmaster1 commented May 23, 2020

jreback commented Jun 14, 2020

ShaharNaveh Mar 5, 2020 •

edited

Loading

ShaharNaveh Mar 5, 2020 •

edited

Loading

ShaharNaveh Mar 5, 2020 •

edited

Loading