Skip to content

Fix typos in 09_timeseries.rst #33226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions doc/source/getting_started/intro_tutorials/09_timeseries.rst
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ objects. In pandas we call these datetime objects similar to

pd.read_csv("../data/air_quality_no2_long.csv", parse_dates=["datetime"])

Why are these :class:`pandas.Timestamp` objects useful. Let’s illustrate the added
Why are these :class:`pandas.Timestamp` objects useful? Let’s illustrate the added
value with some example cases.

What is the start and end date of the time series data set working
Expand All @@ -106,7 +106,7 @@ value with some example cases.

air_quality["datetime"].min(), air_quality["datetime"].max()

Using :class:`pandas.Timestamp` for datetimes enable us to calculate with date
Using :class:`pandas.Timestamp` for datetimes enables us to calculate with date
information and make them comparable. Hence, we can use this to get the
length of our time series:

Expand All @@ -122,7 +122,7 @@ from the standard Python library and defining a time duration.
<div class="d-flex flex-row gs-torefguide">
<span class="badge badge-info">To user guide</span>

The different time concepts supported by pandas are explained in the user guide section on :ref:`time related concepts <timeseries.overview>`.
The various time concepts supported by pandas are explained in the user guide section on :ref:`time related concepts <timeseries.overview>`.

.. raw:: html

Expand Down Expand Up @@ -157,7 +157,7 @@ accessible by the ``dt`` accessor.

An overview of the existing date properties is given in the
:ref:`time and date components overview table <timeseries.components>`. More details about the ``dt`` accessor
to return datetime like properties is explained in a dedicated section on the :ref:`dt accessor <basics.dt_accessors>`.
to return datetime like properties are explained in a dedicated section on the :ref:`dt accessor <basics.dt_accessors>`.

.. raw:: html

Expand Down Expand Up @@ -353,7 +353,7 @@ Make a plot of the daily mean :math:`NO_2` value in each of the stations.
<div class="d-flex flex-row gs-torefguide">
<span class="badge badge-info">To user guide</span>

More details on the power of time series ``resampling`` is provided in the user gudie section on :ref:`resampling <timeseries.resampling>`.
More details on the power of time series ``resampling`` is provided in the user guide section on :ref:`resampling <timeseries.resampling>`.

.. raw:: html

Expand All @@ -366,7 +366,7 @@ More details on the power of time series ``resampling`` is provided in the user

- Valid date strings can be converted to datetime objects using
``to_datetime`` function or as part of read functions.
- Datetime objects in pandas supports calculations, logical operations
- Datetime objects in pandas support calculations, logical operations
and convenient date-related properties using the ``dt`` accessor.
- A ``DatetimeIndex`` contains these date-related properties and
supports convenient slicing.
Expand All @@ -382,7 +382,7 @@ More details on the power of time series ``resampling`` is provided in the user
<div class="d-flex flex-row gs-torefguide">
<span class="badge badge-info">To user guide</span>

A full overview on time series is given in the pages on :ref:`time series and date functionality <timeseries>`.
A full overview on time series is given on the pages on :ref:`time series and date functionality <timeseries>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this one is correct as "in"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, "on" is more correct here grammatically, but it sounds clunky, and we can avoid it. I would rephrase the whole thing like so:
For a full overview on time series, see :ref:time series section <timeseries> in the user guide.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @WillAyd tie breaker?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in is maybe more correct, but I don't think worth changing if its the only thing here. @AlexKirko if you want to reformat sentence separately would definitely be welcome


.. raw:: html

Expand Down