Fix typos in 09_timeseries.rst #33226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Apr 1, 2020
| @@ -382,7 +382,7 @@ More details on the power of time series ``resampling`` is provided in the user | |||
| <div class="d-flex flex-row gs-torefguide"> | |||
| <span class="badge badge-info">To user guide</span> | |||
|
|
|||
| A full overview on time series is given in the pages on :ref:`time series and date functionality <timeseries>`. | |||
| A full overview on time series is given on the pages on :ref:`time series and date functionality <timeseries>`. | |||
There was a problem hiding this comment.
i think this one is correct as "in"
There was a problem hiding this comment.
As far as I know, "on" is more correct here grammatically, but it sounds clunky, and we can avoid it. I would rephrase the whole thing like so:
For a full overview on time series, see :ref:time series section <timeseries> in the user guide.
There was a problem hiding this comment.
in is maybe more correct, but I don't think worth changing if its the only thing here. @AlexKirko if you want to reformat sentence separately would definitely be welcome
|
one comment, otherwise LGTM pending green |
WillAyd
approved these changes
Apr 2, 2020
|
Thanks @rogererens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff