-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH/VIZ: Allowing s
parameter of scatter plots to be a column name
#33107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TomAugspurger
merged 12 commits into
pandas-dev:master
from
SultanOrazbayev:scatter-plot-variable-marker-size
Mar 31, 2020
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cb29cff
added a test for scatter with variable marker size
SultanOrazbayev f5309c8
modified to pass black pandas
SultanOrazbayev ab17f63
check if the size variable is a column
SultanOrazbayev 02c1890
fixed incorrect use of _check_plot_works in a test
SultanOrazbayev abb3d30
added an entry to whatsnew
SultanOrazbayev 4340a41
removed pytest.mark.slow
SultanOrazbayev 7c09214
added docstring to plot.scatter to indicate that column label is also…
SultanOrazbayev 29b0d6c
added versionchanged note
SultanOrazbayev 8a94f08
explicitly verify that marker sizes correspond to the desired values
SultanOrazbayev 4d5db4a
corrected the versionchanged directive
SultanOrazbayev 6896961
modified assertion to use tm
SultanOrazbayev a24e573
changed position of versionchanged
SultanOrazbayev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to have some assertion here that the argument actually had an effect. Perhaps something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I'm confused about the correct way of using
versionchanged
. I read https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html and I think this is suitable:https://github.com/SultanOrazbayev/pandas/blob/4d5db4ad9b30bb51e9c9bbe130ceff4dfb989320/pandas/plotting/_core.py#L1471-L1477
However, not sure about the indentation and whether second argument to
versionchanged
is needed (searching pandas code shows that sometimes the description is added, but it's not everywhere).