Skip to content

ENH/VIZ: Allowing s parameter of scatter plots to be a column name #33107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 31, 2020
Merged

ENH/VIZ: Allowing s parameter of scatter plots to be a column name #33107

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cb29cff
added a test for scatter with variable marker size
SultanOrazbayev Mar 28, 2020
f5309c8
modified to pass black pandas
SultanOrazbayev Mar 28, 2020
ab17f63
check if the size variable is a column
SultanOrazbayev Mar 28, 2020
02c1890
fixed incorrect use of _check_plot_works in a test
SultanOrazbayev Mar 28, 2020
abb3d30
added an entry to whatsnew
SultanOrazbayev Mar 28, 2020
4340a41
removed pytest.mark.slow
SultanOrazbayev Mar 29, 2020
7c09214
added docstring to plot.scatter to indicate that column label is also…
SultanOrazbayev Mar 31, 2020
29b0d6c
added versionchanged note
SultanOrazbayev Mar 31, 2020
8a94f08
explicitly verify that marker sizes correspond to the desired values
SultanOrazbayev Mar 31, 2020
4d5db4a
corrected the versionchanged directive
SultanOrazbayev Mar 31, 2020
6896961
modified assertion to use tm
SultanOrazbayev Mar 31, 2020
a24e573
changed position of versionchanged
SultanOrazbayev Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.1.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,7 @@ Other
- Fixed bug in :func:`pandas.testing.assert_series_equal` where dtypes were checked for ``Interval`` and ``ExtensionArray`` operands when ``check_dtype`` was ``False`` (:issue:`32747`)
- Bug in :meth:`Series.map` not raising on invalid ``na_action`` (:issue:`32815`)
- Bug in :meth:`DataFrame.__dir__` caused a segfault when using unicode surrogates in a column name (:issue:`25509`)
- Bug in :meth:`DataFrame.plot.scatter` caused an error when plotting variable marker sizes (:issue:`32904`)

.. ---------------------------------------------------------------------------

Expand Down
2 changes: 2 additions & 0 deletions pandas/plotting/_matplotlib/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,6 +934,8 @@ def __init__(self, data, x, y, s=None, c=None, **kwargs):
# hide the matplotlib default for size, in case we want to change
# the handling of this argument later
s = 20
elif is_hashable(s) and s in data.columns:
s = data[s]
super().__init__(data, x, y, s=s, **kwargs)
if is_integer(c) and not self.data.columns.holds_integer():
c = self.data.columns[c]
Expand Down
6 changes: 6 additions & 0 deletions pandas/tests/plotting/test_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1306,6 +1306,12 @@ def test_plot_scatter_with_c(self):
float_array = np.array([0.0, 1.0])
df.plot.scatter(x="A", y="B", c=float_array, cmap="spring")

def test_plot_scatter_with_s(self):
# this refers to GH 32904
df = DataFrame(np.random.random((10, 3)) * 100, columns=["a", "b", "c"],)

_check_plot_works(df.plot.scatter, x="a", y="b", s="c")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have some assertion here that the argument actually had an effect. Perhaps something like

Suggested change
_check_plot_works(df.plot.scatter, x="a", y="b", s="c")
ax = df.plot.scatter(x="a", y="b", s="c")
assert len(set(ax.collections[0].get_sizes())) > 1

Copy link
Contributor Author

@SultanOrazbayev SultanOrazbayev Mar 31, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'm confused about the correct way of using versionchanged. I read https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html and I think this is suitable:

https://github.com/SultanOrazbayev/pandas/blob/4d5db4ad9b30bb51e9c9bbe130ceff4dfb989320/pandas/plotting/_core.py#L1471-L1477

However, not sure about the indentation and whether second argument to versionchanged is needed (searching pandas code shows that sometimes the description is added, but it's not everywhere).


def test_scatter_colors(self):
df = DataFrame({"a": [1, 2, 3], "b": [1, 2, 3], "c": [1, 2, 3]})
with pytest.raises(TypeError):
Expand Down