ENH/VIZ: Allowing s parameter of scatter plots to be a column name
#33107
Conversation
datapythonista
changed the title
s parameter of scatter plots to be a column name
datapythonista
changed the title
s parameter of scatter plots to be a column names parameter of scatter plots to be a column name
There was a problem hiding this comment.
lgtm, thanks @SultanOrazbayev
@TomAugspurger if you want to have a look...
pandas/tests/plotting/test_frame.py
Outdated
| # this refers to GH 32904 | ||
| df = DataFrame(np.random.random((10, 3)) * 100, columns=["a", "b", "c"],) | ||
|
|
||
| _check_plot_works(df.plot.scatter, x="a", y="b", s="c") |
There was a problem hiding this comment.
It would be good to have some assertion here that the argument actually had an effect. Perhaps something like
| _check_plot_works(df.plot.scatter, x="a", y="b", s="c") | |
| ax = df.plot.scatter(x="a", y="b", s="c") | |
| assert len(set(ax.collections[0].get_sizes())) > 1 |
There was a problem hiding this comment.
Actually, I'm confused about the correct way of using versionchanged. I read https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html and I think this is suitable:
However, not sure about the indentation and whether second argument to versionchanged is needed (searching pandas code shows that sometimes the description is added, but it's not everywhere).
|
Thanks @SultanOrazbayev. Congrats on your first PR to pandas! |
|
Thank you very much for your help! Glad it worked out! |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis PR is a continuation of #32937 (made an error when pulling changes from the master).
I had a more elaborate decision tree for what to do with a passed size variable
s, here #32937, but in the end decided to go with the simpler version since the other checks are redundant (they would contains=sorpass).