Skip to content

BUG: ensure consistent behavior of Index.is_all_dates (#19204) #33104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

BUG: ensure consistent behavior of Index.is_all_dates (#19204) #33104

wants to merge 3 commits into from

Conversation

addammy
Copy link

@addammy addammy commented Mar 28, 2020

jreback
jreback requested changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look ok, merge master and ping on green

@jreback jreback added the Index Related to the Index class or subclasses label Mar 29, 2020
@addammy addammy requested a review from jreback April 14, 2020 08:49
@jbrockmendel
Copy link
Member

@addammy can you rebase

@addammy addammy force-pushed the is_all_dates_consistency branch from 7bc36c2 to 347a894 Compare April 16, 2020 19:34
@addammy
Copy link
Author

addammy commented Apr 16, 2020

@addammy can you rebase

Done

@jbrockmendel
Copy link
Member

@addammy can you try to get the CI passing

@addammy addammy force-pushed the is_all_dates_consistency branch from 347a894 to 24b1f92 Compare May 4, 2020 15:10
@jreback
Copy link
Contributor

jreback commented Jun 14, 2020

can you merge master; ping on green.

@jreback jreback added this to the No action milestone Jul 17, 2020
@jreback
Copy link
Contributor

jreback commented Jul 17, 2020

closing as stale
if u want to continue pls ping

@jreback jreback closed this Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback Awaiting requested review from jreback

Assignees
No one assigned
Labels
Index Related to the Index class or subclasses
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"is_all_dates" inconsistent across datetimelike types
3 participants
@addammy @jbrockmendel @jreback