BUG: ensure consistent behavior of Index.is_all_dates (#19204) - improved tests, removed unnecessary imports

Author: addammy

pandas/core/indexes/base.py

@@ -8,7 +8,7 @@
 
 from pandas._libs import algos as libalgos, index as libindex, lib
 import pandas._libs.join as libjoin
-from pandas._libs.lib import is_datetime_array, no_default
+from pandas._libs.lib import no_default
 from pandas._libs.tslibs import OutOfBoundsDatetime, Timestamp
 from pandas._libs.tslibs.period import IncompatibleFrequency
 from pandas._libs.tslibs.timezones import tz_compare
@@ -25,7 +25,6 @@
 from pandas.core.dtypes.common import (
     ensure_categorical,
     ensure_int64,
-    ensure_object,
     ensure_platform_int,
     is_bool,
     is_bool_dtype,

pandas/tests/indexes/test_base.py

@@ -1198,8 +1198,12 @@ def test_is_object(self, index, expected):
             ("bool", False),
             ("categorical", False),
             ("int", False),
-            ("datetime", True),
             ("float", False),
+            ("datetime", True),
+            ("datetime-tz", True),
+            ("period", True),
+            ("timedelta", True),
+            ("empty", False),
         ],
         indirect=["index"],
     )
@@ -1208,7 +1212,7 @@ def test_is_all_dates(self, index, expected):
 
     @pytest.mark.parametrize(
         "index",
-        ["datetime", "datetime-tz", "period", "timedelta", "empty"],
+        ["datetime", "datetime-tz", "period", "timedelta"],
         indirect=["index"],
     )
     def test_is_all_dates_consistency(self, index):