-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Fixing links to the contributing page #33029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6a51304
Updated links
76022ea
Merge remote-tracking branch 'upstream/master' into UPDATE-md
6d4d494
Merge remote-tracking branch 'upstream/master' into UPDATE-md
cc79a50
Merge remote-tracking branch 'upstream/master' into UPDATE-md
636e8cb
Merge remote-tracking branch 'upstream/master' into UPDATE-md
69df943
Merge remote-tracking branch 'upstream/master' into UPDATE-md
18a8ead
Fixed URL
2c77e22
Merge remote-tracking branch 'upstream/master' into UPDATE-md
1838dcb
Using new URL
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think should just use pandas.pydata.org but cc @datapythonista
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to move things forward with the hosting, domains... but there are some issues. Will try to find a solution soon (whether it's with OVH as planned, or with the current server, where there are also issues).
I think the idea is to simply use pandas.pydata.org, and stop using pandas.io, dev.pandas.io, pandas-docs.github.io...
There shouldn't be a dev website anymore, because we'll push the master website to production at every commit.
And the dev docs should be at https://pandas.pydata.org/docs/dev/ if I'm not wrong. So, I think this link should be https://pandas.pydata.org/pandas-docs/dev/development/contributing.html or https://pandas.pydata.org/docs/dev/development/contributing.html. @jorisvandenbossche mentioned a preference somewhere, but don't really remember.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was here: #32530 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this link too? https://pandas.pydata.org/docs/dev/ is already working, and I'm planning to stop using the dev.pandas.io domain soon.
If there is any other reference to pandas.io or dev.pandas.io anywhere else in our docs or repo, would be good to replace it too.
Thanks!