Skip to content

DOC: Fixing links to the contributing page #33029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 7, 2020

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Mar 26, 2020

Not 100% sure on this changes.


Feel free to close this at anytime.

@@ -2,7 +2,7 @@

Whether you are a novice or experienced software developer, all contributions and suggestions are welcome!

Our main contributing guide can be found [in this repo](https://github.com/pandas-dev/pandas/blob/master/doc/source/development/contributing.rst) or [on the website](https://pandas-docs.github.io/pandas-docs-travis/development/contributing.html). If you do not want to read it in its entirety, we will summarize the main ways in which you can contribute and point to relevant sections of that document for further information.
Our main contributing guide can be found [in this repo](https://github.com/pandas-dev/pandas/blob/master/doc/source/development/contributing.rst) or [on the website](https://dev.pandas.io/docs/development/contributing.html). If you do not want to read it in its entirety, we will summarize the main ways in which you can contribute and point to relevant sections of that document for further information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think should just use pandas.pydata.org but cc @datapythonista

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to move things forward with the hosting, domains... but there are some issues. Will try to find a solution soon (whether it's with OVH as planned, or with the current server, where there are also issues).

I think the idea is to simply use pandas.pydata.org, and stop using pandas.io, dev.pandas.io, pandas-docs.github.io...

There shouldn't be a dev website anymore, because we'll push the master website to production at every commit.

And the dev docs should be at https://pandas.pydata.org/docs/dev/ if I'm not wrong. So, I think this link should be https://pandas.pydata.org/pandas-docs/dev/development/contributing.html or https://pandas.pydata.org/docs/dev/development/contributing.html. @jorisvandenbossche mentioned a preference somewhere, but don't really remember.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was here: #32530 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this link too? https://pandas.pydata.org/docs/dev/ is already working, and I'm planning to stop using the dev.pandas.io domain soon.

If there is any other reference to pandas.io or dev.pandas.io anywhere else in our docs or repo, would be good to replace it too.

Thanks!

@WillAyd WillAyd added the Docs label Mar 26, 2020
@jreback jreback added this to the 1.1 milestone Mar 29, 2020
@datapythonista datapythonista changed the title Updated links DOC: Fixing links to the contributing page Mar 31, 2020
@@ -14,7 +14,7 @@

For documentation-related issues, you can check the latest versions of the docs on `master` here:

https://pandas-docs.github.io/pandas-docs-travis/
https://pandas.pydata.org/pandas-docs/stable/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shouldn't be stable, but dev. As I mentioned in the other comment, not really sure about the exact path.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shouldn't be stable, but dev. As I mentioned in the other comment, not really sure about the exact path.

@datapythonista does https://pandas.pydata.org/docs/ is the path you meant?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, looks like this is what we're using. Not sure where I've got the pandas-docs from. I guess I've got confused.

@datapythonista
Copy link
Member

@MomIsBestFriend the PR fixing the deployment of the dev docs has been merged. There is a problem in statmodels breaking the docs build atm, but the dev docs should be available at https://pandas.pydata.org/docs/dev/ very soon. If you want to update the links here, that would be great. Thanks!

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MomIsBestFriend, lgtm

@WillAyd WillAyd merged commit cabc31a into pandas-dev:master Apr 7, 2020
@WillAyd
Copy link
Member

WillAyd commented Apr 7, 2020

Thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the UPDATE-md branch April 7, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants