REF: collect to_xarray tests #32877
Merged
REF: collect to_xarray tests #32877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
the
Testing
|
I would create pandas/tests/downstream and move pandas/tests/test_downstream.py to there along with this test file (name is good), maybe even move the xarray test to that (inside test_downstream.py) |
|
ping on green. |
I'll give this some thought. I kind of like test_downstream.py for the specific "dont break downstream" purpose it has no (just asked xarray folks to open a PR with a regression test thatll go there) |
|
hmm needs a rebase |
|
thanks |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
* implement test_to_xarray * dummy commit to force CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm split on where to put test_to_xarray. Since its testing one method, tests/generic/methods/ makes sense. BUT we could try to reserve that directory for tests that are nicely parametrized over Series/DataFrame, which these are not. Thoughts?