Skip to content

REF: pass align_keys to BlockManager.apply #32846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2020

Conversation

jbrockmendel
Copy link
Member

The upcoming branch that implements the last frame-with-series arithmetic ops block-wise is going to need this

@jreback jreback added the Clean label Mar 21, 2020
@jreback jreback added this to the 1.1 milestone Mar 21, 2020
@jreback jreback merged commit 1b49f69 into pandas-dev:master Mar 21, 2020
@jreback
Copy link
Contributor

jreback commented Mar 21, 2020

ok, i bet could remove the align entirely actually, align is a cheap check if things are already aligned (just an index.equals)

@jbrockmendel jbrockmendel deleted the apply-align branch March 21, 2020 21:15
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
jbrockmendel added a commit to jbrockmendel/pandas that referenced this pull request Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants