CLN: remove align kwarg from Block.where, Block.putmask #32791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Mar 18, 2020
jreback
requested changes
Mar 19, 2020
pandas/core/internals/managers.py
Outdated
| align_keys = ["other", "cond"] | ||
| else: | ||
| align_keys = ["cond"] | ||
| elif f == "putmask": | ||
| align_copy = False | ||
| if kwargs.get("align", True): | ||
| if kwargs.pop("align", True): |
There was a problem hiding this comment.
can you completely remove align?
There was a problem hiding this comment.
id like to, but havent been able to yet
5 tasks
|
I thought we merged this, pls rebase |
|
rebased+green |
jreback
approved these changes
Mar 22, 2020
|
thanks |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.