Skip to content

DOC: Fixed contributors for bugfix releases #32827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 23, 2020
Merged

DOC: Fixed contributors for bugfix releases #32827

merged 3 commits into from
Mar 23, 2020

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Mar 19, 2020 •
edited
Loading

Previously we showed just contributors who manually backported commits
to the maintenance branch.

Contributors
============

A total of 8 people contributed patches to this release.  People with a
"+" by their names contributed a patch for the first time.

* Daniel Saxton
* Joris Van den Bossche
* MeeseeksMachine
* MomIsBestFriend
* Pandas Development Team
* Simon Hawkins
* Tom Augspurger
* jbrockmendel

Fixed

Contributors
============

A total of 22 people contributed patches to this release.  People with a
"+" by their names contributed a patch for the first time.

* Anna Daglis +
* Daniel Saxton
* Irv Lustig
* Jan Škoda +
* Joris Van den Bossche
* Justin Zheng +
* Kaiqi Dong
* Kendall Masse +
* Marco Gorelli
* Matthew Roeschke +
* Pedro Reys +
* Prakhar Pandey +
* Robert de Vries +
* Rushabh Vasani +
* Simon Hawkins +
* Stijn Van Hoey +
* Terji Petersen +
* Tom Augspurger
* William Ayd
* alimcmaster1
* gfyoung +
* jbrockmendel

Closes #31717

@TomAugspurger
DOC: Fixed contributors for bugfix releases
7887265 
Previously we showed just contributors who manually backported commits
to the maintenance branch.

```
Contributors
============

A total of 8 people contributed patches to this release.  People with a
"+" by their names contributed a patch for the first time.

* Daniel Saxton
* Joris Van den Bossche
* MeeseeksMachine
* MomIsBestFriend
* Pandas Development Team
* Simon Hawkins
* Tom Augspurger
* jbrockmendel
```

Fixed

```
Contributors
============

A total of 22 people contributed patches to this release.  People with a
"+" by their names contributed a patch for the first time.

* Anna Daglis +
* Daniel Saxton
* Irv Lustig
* Jan Škoda +
* Joris Van den Bossche
* Justin Zheng +
* Kaiqi Dong
* Kendall Masse +
* Marco Gorelli
* Matthew Roeschke +
* Pedro Reys +
* Prakhar Pandey +
* Robert de Vries +
* Rushabh Vasani +
* Simon Hawkins +
* Stijn Van Hoey +
* Terji Petersen +
* Tom Augspurger
* William Ayd
* alimcmaster1
* gfyoung +
* jbrockmendel
```
@TomAugspurger
Copy link
Contributor Author

I guess this will need some more thought. As written, it only works when both the current and previous releases were bugfix releases.

I think we'll want to do both approaches (old and new) and then take the union.

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Mar 19, 2020 •
edited
Loading

New version (for v1.0.1..v1.0.2)

Contributors
============

A total of 25 people contributed patches to this release.  People with a
"+" by their names contributed a patch for the first time.

* Anna Daglis +
* Daniel Saxton
* Irv Lustig
* Jan Škoda
* Joris Van den Bossche
* Justin Zheng
* Kaiqi Dong
* Kendall Masse
* Marco Gorelli
* Matthew Roeschke
* MeeseeksMachine
* MomIsBestFriend
* Pandas Development Team
* Pedro Reys +
* Prakhar Pandey
* Robert de Vries +
* Rushabh Vasani
* Simon Hawkins
* Stijn Van Hoey
* Terji Petersen
* Tom Augspurger
* William Ayd
* alimcmaster1
* gfyoung
* jbrockmendel

@TomAugspurger TomAugspurger added this to the 1.1 milestone Mar 19, 2020
WillAyd
WillAyd reviewed Mar 19, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#31215 was one where the user specifically asked about this, though I don't see them on the list. Any idea what we may be missing there?

doc/sphinxext/announce.py
# We need two passes over the log for cur and prev, one to get the
# "Co-authored by" commits, which come from backports by the bot,
# and one for regular commits.
xpr = re.compile(r"Co-authored-by: (?P<name>[^<]+) ")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be responsible for some issues here; I typically clear out all commit messages before squashing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we'll want to keep it here for backports (GitHub also uses the message I think).

Shouldn't matter for regular PRs, since they use the regular author field, not the message.

@TomAugspurger
Copy link
Contributor Author

#31215 was one where the user specifically asked about this, though I don't see them on the list. Any idea what we may be missing there?

I posted the output for 1.0.1..1.0.2, that commit was in 1.0 (but backported during the RC period IIRC). I've confirmed that their name is in the output for v0.25.3..v1.0.0.

@jorisvandenbossche jorisvandenbossche modified the milestones: 1.1, 1.0.4 Mar 20, 2020
jorisvandenbossche
jorisvandenbossche approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for fixing this!

@jreback
Copy link
Contributor

jreback commented Mar 21, 2020

sure. you tagged for 1.04 ?

@TomAugspurger
Copy link
Contributor Author

Yeah, Joris did.

@TomAugspurger TomAugspurger merged commit d3e5485 into pandas-dev:master Mar 23, 2020
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 23, 2020
@TomAugspurger @meeseeksmachine
Backport PR pandas-dev#32827: DOC: Fixed contributors for bugfix rele…
fdccafe 
…ases
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 23, 2020
Merged
@TomAugspurger TomAugspurger deleted the bugfix-release branch March 23, 2020 13:42
@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Mar 23, 2020 •
edited
Loading

So @pandas-dev/pandas-core when you merge PRs made by the backport bot, make sure to keep the text "Co-Authored by ...". Then the original author will be listed in the "Contributors" section of the 1.0.x docs.

TomAugspurger added a commit that referenced this pull request Mar 23, 2020
@meeseeksmachine @TomAugspurger
Backport PR #32827: DOC: Fixed contributors for bugfix releases (#32928)
2d0acbd 
Co-authored-by: Tom Augspurger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd left review comments

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.0.4
Development

Successfully merging this pull request may close these issues.

Are the contributors in the whatsnew v1.0.1 note correct?
4 participants
@TomAugspurger @jreback @WillAyd @jorisvandenbossche