Skip to content

Are the contributors in the whatsnew v1.0.1 note correct? #31717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcoGorelli opened this issue Feb 5, 2020 · 4 comments · Fixed by #32827
Closed

Are the contributors in the whatsnew v1.0.1 note correct? #31717

MarcoGorelli opened this issue Feb 5, 2020 · 4 comments · Fixed by #32827
Labels

Comments

@MarcoGorelli
Copy link
Member

Having a look at https://github.com/pandas-dev/pandas/milestone/69?closed=1, it seems there's some contributors (e.g. dsaxton , srvanrell) who aren't listed in the whatsnew page: https://pandas.pydata.org/docs/whatsnew/v1.0.1.html

A total of 7 people contributed patches to this release. People with a “+” by their names contributed a patch for the first time.

Guillaume Lemaitre

Jeff Reback

Joris Van den Bossche

Kaiqi Dong

MeeseeksMachine

Pandas Development Team

Tom Augspurger
@TomAugspurger
Copy link
Contributor

I think that's just the issue with the backport bot overwriting the author: scientific-python/MeeseeksDev#35

@MarcoGorelli
Copy link
Member Author

MarcoGorelli commented Feb 5, 2020

Might it be caused by the |HEAD in the whatsnew v1.0.1.rst file?

EDIT

no, sorry, this is not it, HEAD means "head of branch", not the program that only displays the beginning of piped data

@jorisvandenbossche
Copy link
Member

So the bot now actually uses the "Co-authored-by" as I suggested in that linked issue, but now the problem is still that git shortlog -s range doesn't pick those up ..

@WillAyd
Copy link
Member

WillAyd commented Feb 6, 2020

ref #31215 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants