-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Nested list multi index (#14467) #32812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @harri471! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-03-20 19:22:20 UTC |
# This conversion should be safe to do, as the input expects an Index | ||
# and the colums are left unmodified throughout the rest of this function. | ||
columns = ensure_index(columns) | ||
if len(columns) != content_length: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you just combine this check with the one above so you can reuse the same error message?
https://github.com/pandas-dev/pandas/issues/14467 | ||
''' | ||
|
||
class TestNestedListDataMultiIndex: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of creating a new file, could you put these tests in an existing file like pandas/tests/frame/test_constructor.py
@harri471 do you have time do merge in master and address the review comments? |
closing as stale. pls ping if you want to continue / open a new PR. |
columns
argument if nested list is passed in as thedata
parameter. #14467black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff