Skip to content

Avoid bare pytest.raises in indexes/categorical/test_indexing.py #32797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 19, 2020
Merged

Avoid bare pytest.raises in indexes/categorical/test_indexing.py #32797

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1786b2d
Adding message check to pytest.raises for test_dtypes.py
Mar 11, 2020
98110e5
Merge branch 'master' of https://github.com/pandas-dev/pandas
Mar 11, 2020
bf777e8
Readding message check to pytest.raises for test_dtypes.py
Mar 11, 2020
dce255e
Merge branch 'master' of https://github.com/pandas-dev/pandas into 30…
Mar 13, 2020
912b03d
Merge branch 'master' of https://github.com/pandas-dev/pandas into 30…
Mar 18, 2020
20094d9
Fixed bare pytest raises in test_indexing.py.
Mar 18, 2020
f295053
Merge branch 'master' of https://github.com/pandas-dev/pandas into 30…
Mar 18, 2020
5bc868f
Changed two tests as the output appears to be different on some mac a…
Mar 19, 2020
6b8b26b
Merge branch 'master' of https://github.com/pandas-dev/pandas into 30…
Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pandas/tests/indexes/categorical/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ def test_take_fill_value(self):
with pytest.raises(ValueError, match=msg):
idx.take(np.array([1, 0, -5]), fill_value=True)

with pytest.raises(IndexError):
msg = "index -5 is out of bounds for (axis 0 with )?size 3"
with pytest.raises(IndexError, match=msg):
idx.take(np.array([1, -5]))

def test_take_fill_value_datetime(self):
Expand Down Expand Up @@ -104,7 +105,8 @@ def test_take_fill_value_datetime(self):
with pytest.raises(ValueError, match=msg):
idx.take(np.array([1, 0, -5]), fill_value=True)

with pytest.raises(IndexError):
msg = "index -5 is out of bounds for (axis 0 with )?size 3"
with pytest.raises(IndexError, match=msg):
idx.take(np.array([1, -5]))

def test_take_invalid_kwargs(self):
Expand Down