-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Avoid bare pytest.raises in indexes/categorical/test_indexing.py #32797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
simonjayhawkins
merged 9 commits into
pandas-dev:master
from
Vlek:30999_disallow_bare_pytest_raises_test_indexing
Mar 19, 2020
Merged
Avoid bare pytest.raises in indexes/categorical/test_indexing.py #32797
simonjayhawkins
merged 9 commits into
pandas-dev:master
from
Vlek:30999_disallow_bare_pytest_raises_test_indexing
Mar 19, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found a type-o in one of the error messages and corrected it.
� Conflicts: � pandas/tests/dtypes/test_dtypes.py
They got undone due to new commits to pandas.
…999_disallow_bare_pytest_raises_test_indexing
…999_disallow_bare_pytest_raises_test_indexing
…999_disallow_bare_pytest_raises_test_indexing � Conflicts: � pandas/tests/dtypes/test_dtypes.py
…999_disallow_bare_pytest_raises_test_indexing
simonjayhawkins
approved these changes
Mar 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Vlek lgtm
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 23, 2020
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref [Good first issue] TST: Disallow bare pytest.raises #30999
tests added / passed
passes
black pandas
passes
git diff upstream/master -u -- "*.py" | flake8 --diff