Skip to content

Avoid bare pytest.raises in indexes/categorical/test_indexing.py #32797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Vlek
Copy link
Contributor

@Vlek Vlek commented Mar 18, 2020

Derek McCammond added 6 commits March 10, 2020 21:05
Found a type-o in one of the error messages and
corrected it.
� Conflicts:
�	pandas/tests/dtypes/test_dtypes.py
They got undone due to new commits to pandas.
…999_disallow_bare_pytest_raises_test_indexing
…999_disallow_bare_pytest_raises_test_indexing
Vlek added 3 commits March 18, 2020 19:25
…999_disallow_bare_pytest_raises_test_indexing

� Conflicts:
�	pandas/tests/dtypes/test_dtypes.py
…999_disallow_bare_pytest_raises_test_indexing
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Vlek lgtm

@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Mar 19, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Mar 19, 2020
@simonjayhawkins simonjayhawkins merged commit 2247cbe into pandas-dev:master Mar 19, 2020
@Vlek Vlek deleted the 30999_disallow_bare_pytest_raises_test_indexing branch March 19, 2020 13:41
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants