-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Using more fixtures in of tests/base/test_ops.py #32313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Using more fixtures in of tests/base/test_ops.py #32313
Conversation
the diff looks a little mangled; is this all basically un-indent? |
@jbrockmendel Not entirely. I had to extend the tests or add some extra conditions because the fixtures are more versatile than the original test values |
Can these just be split into separate tests for index / series? One-offs are fine but this seems to branch a lot within the test based on the type of object, which makes the purpose of the test less clear |
@WillAyd I guess you're referring to I kept narrow_series and series_with_simple_index separated as I don't want to create another combined fixture with a very narrow use case. Please have another look |
thanks @SaturnFromTitan |
part of #23877
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff