Skip to content

TST: Using more fixtures in of tests/base/test_ops.py #32313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SaturnFromTitan
Copy link
Contributor

part of #23877

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@jbrockmendel
Copy link
Member

the diff looks a little mangled; is this all basically un-indent?

@SaturnFromTitan
Copy link
Contributor Author

@jbrockmendel Not entirely. I had to extend the tests or add some extra conditions because the fixtures are more versatile than the original test values

@WillAyd
Copy link
Member

WillAyd commented Feb 28, 2020

Can these just be split into separate tests for index / series? One-offs are fine but this seems to branch a lot within the test based on the type of object, which makes the purpose of the test less clear

@SaturnFromTitan
Copy link
Contributor Author

@WillAyd I guess you're referring to test_memory_usage as the others don't really branch for logic just relevant to indices or series. I put the series-specific logic of this test into two new ones.

I kept narrow_series and series_with_simple_index separated as I don't want to create another combined fixture with a very narrow use case.

Please have another look

@jreback jreback added the Testing pandas testing functions or related to the test suite label Mar 3, 2020
@jreback jreback added this to the 1.1 milestone Mar 3, 2020
@jreback jreback merged commit 116f8d2 into pandas-dev:master Mar 3, 2020
@jreback
Copy link
Contributor

jreback commented Mar 3, 2020

thanks @SaturnFromTitan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants