Skip to content

CI: temporary fix to the CI #32011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2020
Merged

CI: temporary fix to the CI #32011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pandas/tests/scalar/timedelta/test_arithmetic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,8 +384,11 @@ def test_td_div_nan(self, nan):
result = td / nan
assert result is NaT

result = td // nan
assert result is NaT
# TODO: Don't leave commented, this is just a temporary fix for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure u open an issue

an xfail with a version test is the right way to handle this

i guess ok for right now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback there is already an issue (#31992)

I also think that xfail is the right way to do this, but I am not sure about the value of the "reason" parameter.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MomIsBestFriend the issue will be to revert this PR, which is different. Since I assume that another PR will follow this immediately for that purpose, the issue may not be necessary.

# https://github.com/pandas-dev/pandas/issues/31992

# result = td // nan
# assert result is NaT

# ---------------------------------------------------------------
# Timedelta.__rdiv__
Expand Down