Skip to content

COMPAT: numpy dev version raises new errors during CI #31992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexKirko opened this issue Feb 15, 2020 · 5 comments
Closed

COMPAT: numpy dev version raises new errors during CI #31992

AlexKirko opened this issue Feb 15, 2020 · 5 comments
Labels
CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions

Comments

@AlexKirko
Copy link
Member

Problem description

Looks like something has been changed in numpy, and we now get new errors when running that Numpy dev pipeline during CI. This happens regardless of PR (saw it in #31563 and #31991). Seems to be centered around cumsum and division by nan, but I don't have the time to delve deeper atm.

One of the errors below:

        # axis = 0
        cummin = datetime_frame.cummin()
        expected = datetime_frame.apply(Series.cummin)
>       tm.assert_frame_equal(cummin, expected)

pandas/tests/frame/test_cumulative.py:84: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
pandas/_libs/testing.pyx:65: in pandas._libs.testing.assert_almost_equal
    cpdef assert_almost_equal(a, b,
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

>   raise_assert_detail(obj, msg, lobj, robj)
E   AssertionError: DataFrame.iloc[:, 0] (column name="A") are different
E   
E   DataFrame.iloc[:, 0] (column name="A") values are different (46.66667 %)
E   [left]:  [0.652282807224414, -0.06609607048075124, 6.9221550547283e-310, 4.6661712289503e-310, 4.6661712289503e-310, 0.22575641583650302, 1.5013182000449852, -0.035445399728511705, -0.4007619715825971, -0.4007619715825971, -1.4917178151508124, -0.14834313680366412, 0.545948106375247, 1.495247786960942, 0.2128973463640255, 0.794985190506577, -1.4214210868734076, -1.4214210868734076, -1.019792839223919, -0.28828070056157995, -0.47176522372684804, -0.4267351486193231, -2.816743984494702, 0.4308015055934936, -0.007381576327430263, -0.007381576327430263, -1.121456436411571, -0.25765070817685554, -0.7686775772512485, 1.0963456159671487]
E   [right]: [0.652282807224414, -0.06609607048075124, -0.06609607048075124, 0.48729707348930335, 0.48729707348930335, 0.22575641583650302, 0.22575641583650302, -0.035445399728511705, -0.4007619715825971, -0.4007619715825971, 0.3249965661970306, -0.14834313680366412, -0.14834313680366412, 0.545948106375247, 0.2128973463640255, 0.2128973463640255, -1.4214210868734076, -1.4214210868734076, -0.9987072139900786, -0.9987072139900786, -0.47176522372684804, -0.47176522372684804, -2.816743984494702, -2.816743984494702, -0.007381576327430263, -0.007381576327430263, -1.121456436411571, -1.121456436411571, -0.7686775772512485, -0.7686775772512485]

Link to one of the failed pipelines. You can also just take a look at any recent PR.

@dsaxton
Copy link
Member

dsaxton commented Feb 16, 2020

It seems like the CI stills fails sometimes after #32025 but now perhaps because the tests pass unexpectedly? Not sure what's going on exactly, but does that mean we have to specify that the xfail isn't strict? Here's a pipeline failure after the xfail change: https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=28705&view=logs&j=3a03f79d-0b41-5610-1aa4-b4a014d0bc70&t=4d05ed0e-1ed3-5bff-dd63-1e957f2766a9&l=80

cc @simonjayhawkins

@simonjayhawkins
Copy link
Member

@dsaxton see #32031 for follow-up PR, although having strict=False is not ideal to be able to keep track, so may be better to track down the underlying issue.

@dsaxton
Copy link
Member

dsaxton commented Feb 16, 2020

@dsaxton see #32031 for follow-up PR, although having strict=False is not ideal to be able to keep track, so may be better to track down the underlying issue.

Ah, sorry missed that one

@simonjayhawkins simonjayhawkins added CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions labels Feb 17, 2020
@AlexKirko
Copy link
Member Author

This seems to no longer be a problem.

@simonjayhawkins
Copy link
Member

@AlexKirko can we revert #32025, see #32025 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

No branches or pull requests

3 participants