Skip to content

WIP,CLN: com.ReprMixin everywhere, cls defines __unicode__ and py2/3 #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Mar 26, 2013

str,bytes,repr work.

reduces code duplication and boilerplate.
still need to replace

class Foo(com.ReprMixin,object)

by

class Foo(PrintableObject)

lots of churn, it'll wait till 0.12.

@jreback
Copy link
Contributor

jreback commented Mar 27, 2013

@y-p in 0.12 can do this before my #2915 where I moved all these routines to generic (as part if PandasObject)

but I'll just rebase after u merge and take your changes

@ghost
Copy link
Author

ghost commented Mar 27, 2013

I think we'll do a "big change" merge period right after 0.12, some things have
accumelated.

This is trivial to fixup compared to your refactor. after you...

@ghost ghost closed this Apr 23, 2013
@ghost ghost deleted the repr_refactor branch December 20, 2013 15:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant