-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Establish a PandasBaseObject for all pandas objects #3231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
with #2915 (and others), will be able to unify all primary objects with I would just add needed methods to |
|
Sure, I'm +1 on having a base object to be able to say concretely "here be pandas". Have to be careful about how that class makes its way into, say, tslib.pyx if you want it to be a superclass of Timestamp |
no I agree..... I think may be able to entirely drop |
Great, that's quite the concensus. names... whatever. we'll draw lots. |
closed via #4092 |
generic.PandasObject
is not it since it applies to data containers, notPeriod
orTimeStamp
for example.Should leverage subclasse's
__unicode__
to do the right thingon py2/py3 when it comes to repr,str,bytes #3183
I suggest putting in a mandatory
self.random_example()
(name?) methodthat generates a random instance of the object. Convenient for testing, and for code snippets
in test cases/issues. Complements the more general
makeX
generator functions in util.testing.Side benefit, can more easily add one-size-fits-all sanity check for a pickle roundrip,
which would have caught #2891.
More ideas?
The text was updated successfully, but these errors were encountered: