CLN: _convert_scalar_indexer only handle "loc" and "getitem" #31709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_convert_scalar_indexer
is called with kind="iloc" from only one place, and in that caseself._validate_indexer("positional", key, "iloc")
So by inlining that 1-liner, we can take the "iloc" case out of
_convert_scalar_indexer
altogether.kind=None is never passed, so we can rip that right out.
Ultimately I want to disentable/de-duplicate/disambiguate
_convert_scalar_indexer
vs_maybe_cast_indexer
Partial overlap with #31625.