CLN: inline indexing 1-liners #31625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f-indexing-1liners
…f-indexing-1liners
…f-indexing-1liners
…f-indexing-1liners
…f-indexing-1liners
jbrockmendel
added
Clean
Indexing
jreback
reviewed
Feb 5, 2020
pandas/core/series.py
Outdated
| def _slice(self, slobj: slice, axis: int = 0, kind=None) -> "Series": | ||
| slobj = self.index._convert_slice_indexer(slobj, kind=kind or "getitem") | ||
| def _slice(self, slobj: slice, axis: int = 0, kind: str = "getitem") -> "Series": | ||
| # kind is either "getitem" or "iloc" |
There was a problem hiding this comment.
updated with assertion
|
also needs rebase |
…f-indexing-1liners
|
rebased+green |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only 2-liners here are _convert_scalar_indexer and _convert_slice_indexer, which are effectively
axis = min(axis, self.ndim-1), but that is unnecessary since all places where these are called have axis < self.ndim.