BUG: pd.crosstab(s1, s2) handle column index incorrectly when both series have tuple names #30978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Jan 13, 2020
pandas/tests/reshape/test_pivot.py
Outdated
| @@ -2549,6 +2549,53 @@ def test_crosstab_tuple_name(self, names): | |||
| result = pd.crosstab(s1, s2) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| @pytest.mark.parametrize( | |||
| "s1_data, s1_name, s2_data, s2_name, " | |||
| "expected_index, expected_column, expected_data", | |||
There was a problem hiding this comment.
what is the unique feature between these sets of parameters you are trying to test? Wasn't immediately clear to me; may be OK to do without it if it simplifies test
There was a problem hiding this comment.
yeah, removed. the unique feature was different shape of output, and with one of index or column having same value, like [1,1,1], but probably made it unclear. I now just used the example described in the issue
jreback
approved these changes
Jan 15, 2020
pandas/core/reshape/pivot.py
Outdated
| @@ -596,6 +598,11 @@ def crosstab( | |||
| **kwargs, | |||
| ) | |||
|
|
|||
| # Remove extra level from `[__dummy__]` pivoting | |||
There was a problem hiding this comment.
can you give a comment on why you are doing this.
|
ping @jreback |
WillAyd
approved these changes
Jan 17, 2020
|
Thanks @charlesdong1991 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff